Merge pull request #6563 from RosettaCommons/roccomoretti/load_with_secret_keys
[Foldit] Allow (scientist) loading of expired puzzles.
It would be helpful to be able for scientists to load expired puzzles. That's currently not possible through the standard client.
However, there is a secret key combination of CAS-N which was set to load specific Dojo puzzles. This functionality can be extended to download and launch any puzzle.
Attempting to launch an old-server puzzle (that is, a puzzle without file contents) will result in a crash -- as this is a secret key functionality, that should be okay.
(No release notes -- internal feature only.)
Merge pull request #6565 from RosettaCommons/roccomoretti/load_solutions_extend
[Foldit] Allow the LoadSaveDialog to be resized
The solutions list scrollable on the LoadSaveDialog was frustratingly small for me. Being able to extend it when Foldit is fullscreen will make it much easier to browse solutions (particularly the shared-with-scientist solutions).
This PR adds a resize handle to the dialog which allows you to extend the size of the dialog.
It also contains a bugfix for the Resizable widget. Occasionally (particularly when you're moving around the main window size) it looks like it could get stuck thinking that the panel size is below the minimum size, and refusing to resize -- even if the resizing would make the panel bigger. The new code in Resizable should stop that from happening.
RELEASE NOTES: Add the ability to resize the Open/Share Solutions panel.
Merge pull request #6566 from RosettaCommons/roccomoretti/fix_load_save_left_panel
[Foldit] Fix issues with the Delete and Load buttons for server solutions in LoadSaveDialog
The Load button when applied to server solutions invoked the downloader, but didn't wait until it was done before launching -- this adds a callback which encapsulates the post-download activity.
The issue with the delete button leaving results was a bit more involved. From my understanding, the issue is that the Boinc object cache for shared solutions is being updated by the server call, but removed entries are never cleared. This updates the server code to remove entries which are no longer on the server.
RELEASE NOTES: Fix Load & Delete buttons for Server Solutions in the Open/Share Solutions panel
Merge pull request #6574 from RosettaCommons/roccomoretti/linux_exit
[Foldit] Fix segfaults during Linux shutdown.
I've noticed segfaults when debugging on Linux, and have tracked it down to trying to access various bits of data during program destruction.
Address this by turning off the Server prior to destroying everything, and avoid re-calling the application shutdown code from within the application shutdown procedure.
RELEASE NOTES: Address Segfaults during closing the program on Linux
Merge pull request #6571 from RosettaCommons/roccomoretti/fix_copy_to_clipboard
[Foldit] Fix copy-to-clipboard error.
The reported copy-shared-solution-to-clipboard crash wasn't actually fixed by my previous fixes (PR #6559).
Instead, it looks like the issue is that the publish_solution API endpoint doesn't send back a JSON 'object', but instead sends an empty string. Be robust to this condition (where the API doesn't actually send anything back).
RELEASE NOTES: Fix issue with copy-to-clipboard in shared solutions panel.
Merge pull request #6557 from RosettaCommons/roccomoretti/add_smiles_to_ligand_prop
[Foldit] Add Formula and SMILES to ligand properties panel
There's been some persistent requests to get better information about the formula (number of atoms) and the SMILES string of the ligand. This PR re-works the Small Molecule Properties panel to add that information.
It also removes the need to click boxes to see the values. (With a little rewrite, actually computing properties does not add appreciably to time.)
Being able to export the SMILES for a ligand has also been a request. As a knowledgeable and determined person would be able to create a SMILES string from the visualization, there's no particular harm in allowing them to use a button to copy it to a clipboard. (The ability to input SMILES strings may be different.)
While I was at it, I also fixed an issue where the ligand properties and view panels were created overlapping.
RELEASE NOTES: Add ligand formula and SMILES string to Small Molecule Properties panel.
Merge pull request #6555 from RosettaCommons/roccomoretti/add_ligand_smiles_field
[Foldit] Add SMILES to the list of short data uploaded.
This will allow better data processing on the server-side. ( This is the client support for crowdgames/foldit-server-rails#674 )
This is tested to be robust to both proposed and existing Foldit server code. (With current server code, the extra payload is just ignored.)
RELEASE NOTES: (None)
Merge pull request #6559 from RosettaCommons/roccomoretti/fix_share_network_issues
[Foldit] Make server interactions more robust.
A traceback from [a bug report](https://fold.it/forum/bugs/copy-to-clipboard-crashes-foldit), indicates that there may be non-Foldit exceptions being thrown from Server calls. We should be able to catch that, and make sure that there's a handleable error which won't cause the client to crash.
(Note that due to indentation changes, the diff is more complicated that it really should be.)
RELEASE NOTES: Fix error handling in server interaction (copy-to-clipboard crashes)
Merge pull request #6556 from RosettaCommons/roccomoretti/fix_uploader_refresh
[Foldit] Fix issue with uploader/downloader refresh.
When I made the updates for #6537 and #6539 which added a downloader progress dialog, I moved the download/upload into a thread, but the refresh-after-download was left in the original thread. This meant that there was an inadvertent reordering, meaning that the refresh wasn't seeing the updated results (because it was being executed before the update in the thread completed.)
This PR moves those refreshes into a callback function which is called after the downloader completes.
RELEASE NOTES: Fix bug with solution upload/download where additional refreshes were needed to see the new state.
Merge pull request #6558 from RosettaCommons/interactive/petrides/fix_residue_mismatch_on_untrim
[Foldit] Update Untrim to Preserve New Residue Type on Mutation
Merge pull request #6549 from RosettaCommons/interactive/petrides/mac_build_fix
[Foldit] Update to XCode Project to Work with More Recent Apple Clang Versions
Merge pull request #6547 from RosettaCommons/interactive/petrides/fix_rephase_for_tracks
[Foldit] Fix Crash For Set Track in Density Refinement Puzzles
Merge pull request #6545 from RosettaCommons/roccomoretti/fix_autoupload
[Foldit] Address race condition in auto solution upload.
We're currently getting disk usage errors with the auto solution upload. It looks like the cause is a race condition where the main thread is adding to the same data structure that the solution thread is uploading from, which results in fresh solutions being immediately uploaded, rather than waiting for the next upload window.
We can move the to-upload data to a local data structure to avoid the race condition. (We just need to make sure to copy the not-yet-uploaded data back if we encounter a server error.)