Merge pull request #5693 from RosettaCommons/roccomoretti/update_submodules
Update various submodules
The assorted submodules have accumulated additional commits in their master branches versus their state in the main repo. Update the various submodules to their most recent master branch status.
(Submodules for build & PyRosetta build weren't touched -- it's assumed that they're at the state they're supposed to be.)
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #5796 from RosettaCommons/roccomoretti/pyrosetta_atomid
Enable wrapping of nested AtomID datastructures for PyRosetta.
PyRosetta apparently needs some additional help to know that it needs to wrap nested templated types. The standard way of doing this is apparently to make a dummy function for PyRosetta only.
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #5786 from RosettaCommons/vmullig/fix_rama_prepro_edge_case
Fix an edge case for bad input files for the rama_prepro scoreterm
Andy Watkins found a bug that produces very hard-to-diagnose errors in scoring: if a rama_prepro map has 0 for any probability entry, it creates NaNs that appear far downstream. This PR adds an error message if a rama_prepro map has 0 for any probability entry. It also switches a few more instances of `new` to use `utility::pointer::make_shared`.
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #5779 from RosettaCommons/vmullig/fix_mpi_build_issue_on_ubuntu
Fix MPI build on newer Ubuntu
Disabling C++ MPI bindings in MPI builds. This is to correct a known issue with newer GCC building against older (e.g. v. 1.10.7) OpenMPI. This is safe to do since (a) we don't use the C++ bindings (only the C bindings), (b) the C++ bindings were redundant and useless anyways, and (c) the C++ bindings have been removed in OpenMPI 4.
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #5769 from RosettaCommons/vmullig/generalize_virtual_residue
Generalize the virtual residue patch.
Currently, the protein virtual residue patch is special-cased for each amino acid type, and doesn't support terminal types. This is silly. We have a `VIRTUALIZE_ALL` `PatchOperation` (which is used for RNA); we might as well use it for everything.
Tasks:
- [x] Switch patch to use `VIRTUALIZE_ALL`.
- [x] Rename patch from `VirtualProteinResidue` to `VirtualResidue`.
- [x] Ensure the `VIRTUALIZE_ALL` `PatchOperation` also zeros the net formal charge.
- [x] Unit test to confirm that this lets us virtualize all residues in a pose.
notify author
notify list [rosetta-logs@googlegroups.com]