Merge pull request #3968 from RosettaCommons/roccomoretti/interactive_pointer_checks
Foldit: Add checks to access_ptr usage.
Looking at some of the bug reports coming in, I have a strong suspicion that a bunch of the obscure crashes are related to memory corruption due to object lifetime issues.
Part of this might be down to Foldit's heavy reliance on access pointers. The current implementation of Foldit APs doesn't provide any guarantees/safety regarding object validity when using APs. This PR augments the current APs with a validity CheckObject which gets invalidated when the object is deleted.
To make sure checks run, I knocked out a bunch of the AP->raw pointer conversions. This has the added benefit of adding AP/OP conversion functions. This also switches boost::bind() to interactive::util::bind(), which has better support for maintaining object validity for the duration of the call to a member function callback.
The one downside for interactive::util::bind is that, due to C++ templating rules, it doesn't play well with overloaded member functions. As such, when you wrap overloaded member functions, you may need to use interactive::util::bind_op instead. (And potentially add to the bind_op rules in interactive/util/bind.hh.)
RELEASE NOTES: Improve error handling and reporting for a class of obscure crashes.
Merge pull request #3818 from RosettaCommons/roccomoretti/win_handle_leak
Foldit: Fix handle leak on Windows.
Unlike Posix, on Windows you need to explicit close the handle after joining. (see e.g. https://stackoverflow.com/q/14211958/3022952).
This should hopefully address the issues seen in https://fold.it/portal/node/2004487
Merge pull request #3688 from RosettaCommons/jflat06/interactive_events_refactor
Foldit: Refactor event/state system to be consistent with the standalone refactor
Merge pull request #3766 from RosettaCommons/roccomoretti/interactive_fix_unit_tests
Foldit: Fix unit test for Foldit
This fixes some of the broken unit tests in interactive/develop.
Merge pull request #3686 from RosettaCommons/roccomoretti/interactive_thread_safety_analysis
Foldit: Enable ThreadSafetyAnalysis and fix issues related there-to
This adds a (Linux Clang) build which looks at thread safety issues. To enable this, various annotations are made. (For normal builds these annotations are empty defines.) Right now it's just the GUI mutex which is so annotated, and mainly for pose access issues.
* HOLD_GUI_MUTEX_TO_USE and HOLD_GUI_MUTEX_TO_DEREF -- annotations for data members, indicating that the GUI mutex should be held to access/dereference data.
* NEEDS_GUI_MUTEX_LOCKED -- annotation for functions, indicating that the function assumes that the gui mutex is being held by the caller.