Merge pull request #5745 from RosettaCommons/roccomoretti/interactive_float_menu_wrap_layout_change
[Foldit] Adjust Action Float Menu wrapping
Adjust how the Action Menu wrapping works. Several changes:
1 Icons now wrap left to right, bottom to top, rather than the old way of filling out the second and third rows back to front. (Where the second row started with the last icon of the all-in-one-row and filled in reverse order from the all-in-one-row, and the third row was the middle of the action bar. We got comments, so hopefully this is a bit more intuitive, even if they move around a bit more on a window resize.
2 Sub-float menus (like the secondary structure and the manual mutation panel) base their position dynamically on the action float menu, so will automatically move down/up if they're open when the window resizes.
3 We now query the actual size of the chat tab, rather than the almost-but-apparently-not-quite hard coded value we were using. This fixes some overlap issues.
4 As a consequence of 3), in offline mode (and Standalone) we can now make use of the full bottom bar, rather than having an empty spot where the char bar would be.
A future goal would be to shrink the chat windows for small screen sizes, to keep more real estate for the action bar, but that change isn't part of this PR.
(For completeness, I should point out I changed how the animation of the FloatMenu button positions work. This now supports Y movement as well as X movement. -- We don't actually use the animations anymore, though, as the menus should come in in their completed form, and icon movement on resize is distracting.)
Merge pull request #5746 from RosettaCommons/roccomoretti/interactive_center_score
[Foldit] Center Score in Score Panel.
The score is not centered within the score panel, which leads to slightly off scores, particularly when they get long (see the starting score for the current AlphaFold design puzzle). Part of the reason for this is the attempt at support for the fractional score progress gauge.
We don't ever use this anymore (we have "advanced" mode permanently turned on, except for some tutorial puzzles, which have their own score display.) Rip out the fractional score support, and just put the full score directly in the score panel, which allows us to center it better.
Merge pull request #5740 from RosettaCommons/roccomoretti/interactive_fix_gui_toggle
[Foldit] Fix logic bug for GUI toggle.
As part of PR #5733 I added a convenience function to re-enable the GUI elements if you clicked on the menu button.
This was only supposed to be active if you had the GUI hide enabled, but I messed up the logic a bit, and turned the main icon into a general GUI Hide toggle. This should fix it.
Merge pull request #5719 from RosettaCommons/jtscott/interactive_puzzle_expiration
[Foldit] Display Puzzle Expiration
The puzzle expiration for the new UI was removed, but due to player requests, I have added it in two places:
Display puzzle expiration on title tool tip
When the player hovers over the title, the full title, and the puzzle expiration will now be displayed
Display puzzle expiration on the Score Panel when one day is remaining
One of the design choices for the Score Panel was to keep it as clutter free as possible.
To help with this the puzzle expiration will only be displayed on the Score Panel when one day remains.
Merge pull request #5736 from RosettaCommons/roccomoretti/interactive_view_hotkey_fix
[Foldit] Re-enable View Option hotkeys.
Several things going on. We needed to update how we were working with refresh() to make sure that the StandaloneViewOptions were being properly enabled. Then we needed to make sure that the two view windows (preset and old-style) weren't conflicting with each other with respect to the hotkey registration. There's also some missing observer attachment that needed to get fixed.
Merge pull request #5743 from RosettaCommons/jtscott/interactive_strikethrough_position
[Foldit] Strikethrough Y Axis Position Fix
The Strikethrough y axis position was altered unintentionally. This PR removes that adjustment
Merge pull request #5741 from RosettaCommons/joshmiller/cookbook-update
[Foldit] Replace GUI recipe in cookbook starter pack
No release notes? or "updated the Cookbook starter pack"
Merge pull request #5737 from RosettaCommons/roccomoretti/interactive_residues_selected
[Foldit] Add back in the selection info string.
This is placed in the lower left hand corner. (The concept is that we can use this area to do more with selections/actions in the future.)
Merge pull request #5734 from RosettaCommons/jtscott/interactive_score_panel_size_adjustment
[Foldit] Removed the Score Title from Score Panel
This PR is designed to address the players concerns that the score panel was too big and taking up too much space.
* The Score Title has been removed.
* The Score panel has been reduced in width
Merge pull request #5729 from RosettaCommons/jtscott/interactive_player_rank_display
[Foldit] Player Rank Display
The current rank of the soloist/evolver and group are now displayed in the scoreboard menu.
Merge pull request #5728 from RosettaCommons/jtscott/interactive_backbone_pins
[Foldit] Backbone Pin Display Bug Fix
The logic governing backbone pins had been removed without the removal of the View Options checkbox. This made the checkbox not work. I believe this was done by mistake. This PR adds it back in.
Merge pull request #5735 from RosettaCommons/jtscott/interactive_missing_view_options_bug_fix
[Foldit] Missing View Options Bug
Players noticed outlines were being activated on every puzzle load. This was because the check for active or inactive outlines had been removed.This bug was also noticed in @bkoepnick's PR: #5711 Check for the outlines and a few others that were missing have been added back in. This should also take care of the side chain hbond bug fixed in PR #5732, making it unneeded.
Merge pull request #5718 from RosettaCommons/roccomoretti/interactive_fix_unit_tests
[Foldit] Fix unit tests.
A hodge-podge of fixes to address unit test issues. All unit tests should now complete successfully, either on the test server or my machine.
* Remove sinpass test (as the function it was testing was removed in Henry's master-normalization fix.)
* Update numbers on a core-existence filter test. (I hope this was the right thing to do -- I'm not sure if this might be hiding a larger issue.
* Update GameApplication tests for the presence of the Roles (EduMode) popup box on login.
* Fix unit test maximum iterations settings, now that we're going through the SelectionTool for shake/wiggle.
* Fix selection of undo menu selection, for the new interface
* Fix issue with modal popup ("This protein's structure is known. See if you can match it!") for puzzle score tests.
I also added some more advanced debugging output, so hopefully debugging modal dialog box issues is easier in the future.
Note that the GameApplication and Action tests work on my machine, but are still having issues on the test server, probably due to GLX issues.