Merge pull request #4276 from RosettaCommons/vmullig/fix_pose_from_sfr_builder
Fix a bug in the PoseFromSFRBuilder
The -in:Ctermini and -in:Ntermini options aren't working as expected. This ensures that, if the user uses these, they properly apply termini only to those chains that are listed.
This also adds a unit test for the desired functionality.
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #4285 from RosettaCommons/vmullig/fix_rollmover_again
Trying to fix Rollmover ubsan test.
I think the problem is that the Rollmover doesn't initialize all of its variables in both constructors. This creates problems on copying, when, for example, a boolean variable is initialized with a non-binary value.
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #4284 from RosettaCommons/jkleman/SciBen_fixes_and_cutoffs
Jkleman/sci ben fixes and cutoffs
Fixing a bunch of small things in various scientific tests. For instance, some cutoffs to make them pass.
* mp_symdock still needs to be fixed, this is a bigger issue next on my list
* dock_glycans requires some fixes and thresholds adjusted still, next on my list
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #4281 from RosettaCommons/roccomoretti/clang_tidy_test_fixes
Fixes for clang-tidy issues
This merge both adds a new test server test which runs clang-tidy on the Rosetta code base, as well as fixing a number of issues which the default clang-tidy settings identify. (Mostly using virtual functions in constructors and destructors, but a smattering of other issues.)
There are a couple of places where the current (C++ standard-mandated) behavior probably isn't what is intended, but I've added comments to those, so hopefully people looking at it in the future can figure out if they want/need to change things.
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #4282 from RosettaCommons/dimaio/glycan_cartrefine_fixes_2
More fixes for glycans:
- fix amide H generation for N acetylation patches
- fix bug with symmetrization of poses containing free glycans
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #3858 from RosettaCommons/JWLabonte/sugars/scientific_benchmarking
Carbohydrates: Adding scientific benchmark for dock_glycans protocol
tests still failing, cutoffs will be adjusted after talking with Labonte
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #4227 from RosettaCommons/rfalford12/fix-mp-docking-tests
Rebecca's fix to mp_dock and mp_symdock - I thought this was merged weeks ago but in fact, I missed it. Thanks Rebecca!!!
notify author
notify list [rosetta-logs@googlegroups.com]
Merge pull request #4272 from RosettaCommons/sergey/notebook
Updating `PyRosetta4.notebook` test:
- adding DEBUG environment variable
- refactoring execution to run in parallel
- switching to use iPython during execution
- adding matplotlib and biopython packages
notify author
notify list [rosetta-logs@googlegroups.com]