Pull Request №697 RosettaCommons/rosetta/main ← lyskov-ai/rosetta/refactor/rule-of-zero-batched-fixes
Merge: d10f3af574b60550f256856d5a9742600ce1128b←5d92187e14c53fcb0249c5ee8f5426908f3a44e3
Apply Rule of Zero to old-style uncopyable classes in core/ and protocols/
----------------
Merge commit message:
Remove dead private fields exposed by = delete copy modernization
Clang's -Wunused-private-field is suppressed while a class has any
declared (even unimplemented) private copy constructor / assignment,
because the compiler can't prove those bodies don't touch the field.
Replacing those declarations with = delete in PR #697 let clang fully
analyze member usage, surfacing five orphaned scalar fields whose only
references live inside large /* ... */ blocks of disabled I/O code:
- DoubleLazyNode::procrastinated_
- LazyNode::procrastinated_
- LazyInteractionGraph::num_aa_types_
- PDInteractionGraph::num_nodes_in_file_
- PDInteractionGraph::num_file_aa_types_
Drop the fields and the matching constructor initializers. The commented
I/O functions that reference them are left alone (already dead).