「view this page in B3 βῆτα server」

Revisions №61382

branch: master 「№61382」
Commited by: Vikram K. Mulligan
GitHub commit link: 「6dedbd4c240c738a」 「№4928」
Difference from previous tested commit:  code diff
Commit date: 2020-08-22 17:41:05
linux.clang linux.gcc linux.srlz mac.clang
PyRosetta4.notebook gcc-9.gcc.python37.PyRosetta4.unit linux.clang.cxx11thread.serialization.python37.PyRosetta4.unit linux.gcc.python36.PyRosetta4.unit mac.PyRosetta.unit build.clean.debug alpine.gcc.build.debug clang-10.clang.cxx11thread.mpi.serialization.tensorflow.build.debug gcc-9.gcc.build.debug mysql postgres linux.clang.python36.build.debug linux.zeromq.debug mpi mpi.serialization linux.icc.build.debug OpenCL mac.clang.python36.build.debug build.header build.levels build.ninja_debug graphics static build.xcode beautification code_quality.clang_analysis code_quality.clang_tidy code_quality.cppcheck serialization code_quality.submodule_regression integration.mpi integration.release_debug integration.tensorflow integration.thread integration performance profile release.source scientific.antibody_snugdock linux.clang.score linux.gcc.score mac.clang.score linux.scripts.pyrosetta scripts.rosetta.parse scripts.rosetta.validate scripts.rosetta.verify linux.clang.unit.release linux.gcc.unit.release gcc-9.gcc.unit util.apps

Merge pull request #4928 from RosettaCommons/vmullig/tidy_up_clang_tidy_warnings Removing unused values flagged by clang-tidy. Note that the operator() called here has no side-effects; its ONLY effect is to return a value that's never used, so it's safe to delete it. Additional notes added by Rocco: Looking at the code and #4890, it looks like the removal is fine. The computation that was previously done with these variables has been moved to the output_interface_deltas(). Presuming the component energies sum to the total scores, then the transformation should be valid. (As the difference of the sums of the components should be equal to the sums of the differences in components.) ... Well, with the caveat that you're either not using the normalization function, or that the normalization function is a linear (not affine) scaling, and the sum of normalized components is equal to the normalized sum of components. -- But looking through the current options for normalization factors, that's the case. (And the normalization option isn't used much, anyway.)

Test: mac.clang.python27.build.xcode

 View log


 View log in dialog  View log in log in separate window
Test: linux.clang.performance

Failed sub-tests (click for more details):