Merge pull request #4363 from RosettaCommons/roccomoretti/clang_tidy_3
Fix issues identified by the misc-* series of clang-tidy tests.
Part of my slow effort to extend the things we test for with clang-tidy.
Most of the changes are due to removal of unused using statements (misc-unused-using-decls) or the conversion of std::string::compare() to std::string::operator== (misc-string-compare -- seriously, there's no reason to use the single-argument version of std::string::compare(). operator== is overloaded for char*, and the semantics of the return value make it hard to read.)
Other issues include converting ad hoc rounding to use the standard library (misc-incorrect-roundings), fixing up some potentially error prone macros (misc-macro-parentheses), fixing redundant expressions in comparisons (misc-redundant-expression -- some potential bugs here), better annotation of C-style string comparison functions (misc-suspicious-string-compare), non-delegating delgating constructors (misc-undelegated-constructor), catch/throw issues (misc-throw-by-value-catch-by-reference), unused objects (misc-unused-raii - there's a bug remaining here), assigning integers to strings (misc-string-integer-assignment - bugs fixed).
It also caught some bad definitions-in-headers (misc-definitions-in-headers) and some really odd assignment operators (misc-unconventional-assign-operator), but those tests are too noisy to leave on permanently.
There are some behavioral changes from putative bug fixes, but hopefully they're a "fixed" approach.