「view this page in B3 βῆτα server」

Revisions №61100

branch: master 「№61100」
Commited by: Rocco Moretti
GitHub commit link: 「eb01c900dbab5628」 「№4363」
Difference from previous tested commit:  code diff
Commit date: 2020-01-13 16:02:50
linux.clang linux.gcc linux.srlz mac.clang
PyRosetta4.notebook gcc-9.gcc.python37.PyRosetta4.unit linux.clang.cxx11thread.serialization.python37.PyRosetta4.unit linux.gcc.python36.PyRosetta4.unit mac.PyRosetta.unit build.clean.debug cppcheck alpine.gcc.build.debug gcc-9.gcc.build.debug mysql postgres linux.clang.python36.build.debug linux.zeromq.debug mpi mpi.serialization linux.icc.build.debug OpenCL mac.clang.python36.build.debug build.header build.levels build.ninja_debug graphics static linux.ui mac.ui build.xcode beautification code_quality.clang_analysis code_quality.clang_tidy serialization code_quality.submodule_regression integration.mpi integration.release_debug integration.tensorflow integration.thread integration.tutorials integration performance profile release.PyRosetta4.Release release.source scientific.mp_f19_energy_landscape.debug scientific.rna_denovo_favorites.debug linux.clang.score linux.gcc.score mac.clang.score linux.scripts.pyrosetta scripts.rosetta.parse scripts.rosetta.validate scripts.rosetta.verify linux.clang.unit.release linux.gcc.unit.release gcc-9.gcc.unit util.apps

Merge pull request #4363 from RosettaCommons/roccomoretti/clang_tidy_3 Fix issues identified by the misc-* series of clang-tidy tests. Part of my slow effort to extend the things we test for with clang-tidy. Most of the changes are due to removal of unused using statements (misc-unused-using-decls) or the conversion of std::string::compare() to std::string::operator== (misc-string-compare -- seriously, there's no reason to use the single-argument version of std::string::compare(). operator== is overloaded for char*, and the semantics of the return value make it hard to read.) Other issues include converting ad hoc rounding to use the standard library (misc-incorrect-roundings), fixing up some potentially error prone macros (misc-macro-parentheses), fixing redundant expressions in comparisons (misc-redundant-expression -- some potential bugs here), better annotation of C-style string comparison functions (misc-suspicious-string-compare), non-delegating delgating constructors (misc-undelegated-constructor), catch/throw issues (misc-throw-by-value-catch-by-reference), unused objects (misc-unused-raii - there's a bug remaining here), assigning integers to strings (misc-string-integer-assignment - bugs fixed). It also caught some bad definitions-in-headers (misc-definitions-in-headers) and some really odd assignment operators (misc-unconventional-assign-operator), but those tests are too noisy to leave on permanently. There are some behavioral changes from putative bug fixes, but hopefully they're a "fixed" approach.

Test: linux.clang.code_quality.submodule_regression

 View log


 View log in dialog  View log in log in separate window