「view this page in B3 βῆτα server」

Revisions №61014

branch: master 「№61014」
Commited by: Rocco Moretti
GitHub commit link: 「dc7a49ce5d95aa6f」 「№4290」
Difference from previous tested commit:  code diff
Commit date: 2019-10-31 11:50:00
linux.clang linux.gcc linux.srlz mac.clang
debug
release
unit
PyRosetta4.notebook linux.clang.cxx11thread.serialization.python37.PyRosetta4.unit linux.gcc.python36.PyRosetta4.unit mac.PyRosetta.unit build.clean.debug cppcheck mysql postgres linux.clang.python36.build.debug linux.zeromq.debug mpi mpi.serialization linux.icc.build.debug OpenCL mac.clang.python36.build.debug build.header build.levels ninja graphics static linux.ui mac.ui build.xcode beautification code_quality.clang_analysis serialization integration.addsan integration.mpi integration.release_debug integration.tensorflow integration.thread integration performance profile ubuntu.clang.python27.release.PyRosetta4.MinSizeRel ubuntu.clang.python37.release.PyRosetta4.MinSizeRel release.PyRosetta4.Release release.source scientific.ddg_ala_scan scientific.sewing.debug linux.clang.score linux.gcc.score mac.clang.score linux.scripts.pyrosetta scripts.rosetta.parse scripts.rosetta.validate scripts.rosetta.verify unit.addsan linux.clang.unit.release linux.gcc.unit.release util.apps

Merge pull request #4290 from RosettaCommons/roccomoretti/bugprone-integer-division_fix Fix clang-tidy bugprone-integer-division Dividing two integers in C++ gives a (truncated) integer result. This may not be what you want. Clang-tidy has a check to see if you're doing an integer division and then using the result as a floating point. This flags a fair number of examples in Rosetta, some of which are obvious bugs. I've attempted to fix the instances which clang-tidy flags, mainly by converting them to actual floating point results. This may not be the best way to fix some of these, so feel free to adjust such that the intent is clearer. See https://github.com/RosettaCommons/main/pull/4290 for detailed discussion.