「view this page in B3 βῆτα server」

Revisions №60895

branch: master 「№60895」
Commited by: Rocco Moretti
GitHub commit link: 「010c62e53d169813」 「№4170」
Difference from previous tested commit:  code diff
Commit date: 2019-08-24 12:18:29

Merge pull request #4170 from RosettaCommons/roccomoretti/fix_broker_test Fix issue with silent file endianess flipping on Mac. The broker integration test was broken related to the fact that the input silent file was created on a big-endian system. Normally that should be fine, as the binary silent file reading code has checks to flip the endianness of the input when read on an alternate-endian system. However, it looks like those checks weren't working properly on the Mac/Clang test server system. Best I can tell, the Mac/Clang compiler isn't realizing that the bit twiddling we do to flip endianness will change the memory layout, and is effectively optimizing out the check. I'm not exactly sure why that is, but moving the code body from an inlined function to a cc function seems to fix the issue.

...