「view this page in B3 βῆτα server」

Revisions №60894

branch: master 「№60894」
Commited by: Vikram K. Mulligan
GitHub commit link: 「d6ec1a00c4003460」 「№4178」
Difference from previous tested commit:  code diff
Commit date: 2019-08-24 03:18:45
linux.clang linux.gcc linux.srlz mac.clang
linux.clang.cxx11thread.serialization.python37.PyRosetta4.unit linux.gcc.python36.PyRosetta4.unit mac.PyRosetta.unit build.clean.debug cppcheck mysql postgres linux.clang.python36.build.debug linux.zeromq.debug mpi mpi.serialization linux.icc.build.debug OpenCL mac.clang.python36.build.debug build.header build.levels ninja graphics static linux.ui mac.ui build.xcode beautification code_quality.clang_analysis serialization integration.mpi integration.release_debug integration.tensorflow integration.thread integration.tutorials integration.ubsan integration performance profile release.PyRosetta4.Release release.source scientific.cartesian_relax scientific.cofactor_binding_sites.debug scientific.fast_relax_5iter.debug scientific.fast_relax_5iter scientific.mp_dock.debug scientific.mp_dock scientific.mp_relax scientific.mp_symdock.debug scientific.rna_denovo_favorites.debug scientific.stepwise_rna_favorites.debug linux.clang.score linux.gcc.score mac.clang.score linux.scripts.pyrosetta scripts.rosetta.parse scripts.rosetta.validate scripts.rosetta.verify linux.clang.unit.release linux.gcc.unit.release util.apps

Merge pull request #4178 from RosettaCommons/vmullig/fix_minor_helical_bundle_predict_issues Fix minor issues with helical_bundle_predict application that were flagged by clang analysis Clang analysis complains if a variable is assigned a value on initialization if that value is never read. Personally, I think that this should be left to developer discretion. In performance-limiting contexts, this is a waste of a few clock cycles, it's true. In contexts that are _not_ performance-limiting, though, the slight inefficiency can be less important than the avoidance of uninitialized variable errors in the future, if someone adds a read of the variable in question between its declaration and the first assignment. Nevertheless, I'm taking out a couple of initializations that are never read, to keep the clang analysis test happy. (I'm also taking the opportunity to convert a few instances of `vect.push_back( MyClassOP( make_shared< MyClass >( ... ) ) )` into `vect.push_back( make_shared< MyClass >( ... ) )`. There's no need for the extra temporary `MyClassOP`, given that `make_shared` already returns a `MyClassOP`.)

Test: linux.gcc.mpi.serialization.integration.mpi

Failed sub-tests (click for more details):
Test: mac.clang.integration

Failed sub-tests (click for more details):
Test: linux.clang.scientific.mp_dock

 View log


 View log in dialog  View log in log in separate window