Merge pull request #4178 from RosettaCommons/vmullig/fix_minor_helical_bundle_predict_issues
Fix minor issues with helical_bundle_predict application that were flagged by clang analysis
Clang analysis complains if a variable is assigned a value on initialization if that value is never read. Personally, I think that this should be left to developer discretion. In performance-limiting contexts, this is a waste of a few clock cycles, it's true. In contexts that are _not_ performance-limiting, though, the slight inefficiency can be less important than the avoidance of uninitialized variable errors in the future, if someone adds a read of the variable in question between its declaration and the first assignment.
Nevertheless, I'm taking out a couple of initializations that are never read, to keep the clang analysis test happy.
(I'm also taking the opportunity to convert a few instances of `vect.push_back( MyClassOP( make_shared< MyClass >( ... ) ) )` into `vect.push_back( make_shared< MyClass >( ... ) )`. There's no need for the extra temporary `MyClassOP`, given that `make_shared` already returns a `MyClassOP`.)