「view this page in B3 βῆτα server」

Revisions №60749

branch: master 「№60749」
Commited by: Andrew Leaver-Fay
GitHub commit link: 「d8f9b4a90a8f2caa」
Difference from previous tested commit:  code diff
Commit date: 2019-05-30 13:47:16
linux.clang linux.gcc linux.srlz mac.clang
debug
release
unit
linux.PyRosetta.unit linux.gcc.python37.PyRosetta4.unit mac.PyRosetta.unit build.clean.debug cppcheck mysql postgres linux.clang.python36.build.debug linux.zeromq.debug mpi mpi.serialization linux.icc.build.debug OpenCL mac.clang.python36.build.debug build.header build.levels ninja graphics static mac.clang.static.build.release linux.ui mac.ui build.xcode beautification code_quality.clang_analysis serialization integration.addsan integration.mpi integration.release_debug integration.tutorials integration.ubsan integration.valgrind integration maintenance.documentation performance profile linux.clang.python27.release.PyRosetta4.Debug linux.clang.python35.release.PyRosetta4.Debug linux.clang.python36.release.PyRosetta4.Debug linux.clang.python37.release.PyRosetta4.Debug linux.clang.python27.release.PyRosetta4.MinSizeRel linux.clang.python35.release.PyRosetta4.MinSizeRel linux.clang.python36.release.PyRosetta4.MinSizeRel linux.clang.python37.release.PyRosetta4.MinSizeRel ubuntu.clang.python27.release.PyRosetta4.MinSizeRel ubuntu.clang.python35.release.PyRosetta4.MinSizeRel ubuntu.clang.python36.release.PyRosetta4.MinSizeRel ubuntu.clang.python37.release.PyRosetta4.MinSizeRel linux.clang.python27.release.PyRosetta4.Release linux.clang.python35.release.PyRosetta4.Release linux.clang.python36.release.PyRosetta4.Release linux.clang.python37.release.PyRosetta4.Release mac.clang.python37.release.PyRosetta4.Release ubuntu.clang.python27.release.PyRosetta4.Release ubuntu.clang.python35.release.PyRosetta4.Release ubuntu.clang.python36.release.PyRosetta4.Release ubuntu.clang.python37.release.PyRosetta4.Release release.source linux.clang.score linux.gcc.score mac.clang.score linux.scripts.pyrosetta scripts.rosetta.parse scripts.rosetta.validate scripts.rosetta.verify unit.addsan linux.clang.unit.release linux.gcc.unit.release unit.ubsan unit.valgrind util.apps

Fix EnergyMap::operator += (#3977) The convention for increment-and-assign type operators is to return a reference to the object that has just been incremented, thereby facilitating multiple increments in a single statement ``` a += ( b+= c ); ``` The original author* of the EMapVector class (aka EnergyMap) did not realize this and so this class does not return a reference, and instead returns void. This has never been a problem for C++ code as no one has seemingly wanted to chain increment-and-assign operations. PyBind11, however, will take the returned type and assign it to the original object: ``` emap1 += emap2 ``` is interpretted as: ``` emap1 = (emap1 += emap2) ``` so that this code: ``` emap1 += emap2 print("Surpise!", emap1) ``` will print ``` Surprise! None ``` This PR changes the signature of just the EMapVector's operator+= and similar methods, but surely there are other places in the code where operators are not conforming to the C++ conventions. *I am the original author of this code.

...
Test: ubuntu.gcc.integration.addsan

Failed sub-tests (click for more details):
small_molecule_lattice_dock
Test: linux.clang.integration.tutorials

Failed sub-tests (click for more details):
advanced_protein-protein_docking
Test: ubuntu.gcc.integration.ubsan

Failed sub-tests (click for more details):
small_molecule_lattice_dock
Test: linux.clang.performance

Failed sub-tests (click for more details):
core_scoring_Score_100x_envsmooth