「view this page in B3 βῆτα server」

Revisions №60515

branch: master 「№60515」
Commited by: Rocco Moretti
GitHub commit link: 「d4d14d64f3ca60c7」 「№3100」
Difference from previous tested commit:  code diff
Commit date: 2018-11-26 17:16:03
linux.clang linux.gcc linux.srlz mac.clang
linux.PyRosetta.unit linux.gcc.python36.PyRosetta4.unit mac.PyRosetta.unit build.clean.debug cppcheck mysql postgres linux.zeromq.debug mpi mpi.serialization linux.icc.build.debug OpenCL build.header build.levels ninja graphics static mac.clang.static.build.release linux.ui mac.ui build.xcode beautification code_quality.clang_analysis serialization integration.mpi integration.release_debug integration.valgrind integration performance profile linux.clang.python36.release.PyRosetta4.Debug linux.clang.python37.release.PyRosetta4.Debug linux.clang.python27.release.PyRosetta4.MinSizeRel linux.clang.python35.release.PyRosetta4.MinSizeRel linux.clang.python36.release.PyRosetta4.MinSizeRel mac.clang.python35.release.PyRosetta4.MinSizeRel linux.clang.python27.release.PyRosetta4.Release linux.clang.python35.release.PyRosetta4.Release linux.clang.python36.release.PyRosetta4.Release mac.clang.python27.release.PyRosetta4.Release mac.clang.python35.release.PyRosetta4.Release release.source linux.clang.score linux.gcc.score mac.clang.score linux.scripts.pyrosetta scripts.rosetta.parse scripts.rosetta.validate scripts.rosetta.verify linux.clang.unit.release linux.gcc.unit.release

Merge pull request #3100 from RosettaCommons/roccomoretti/sym_scorefunction Make all ScoreFunctions symmetric-aware score functions. Change the implementation of the ScoreFunction class such that the distinction between a SymmetricScoreFunction and a plain ScoreFunction disappears. This means there's no longer a need to match the symmetric status of a scorefunction to that of a pose. As such, this PR also removes a number of places where such symmetric checking is handled. For compatibility with existing PyRosetta scripts, etc. the SymmetricScoreFunction class still exists, it's just a practically-no-difference wrapper around the regular ScoreFunction. Additionally, the `symmetry="1"` in XML will still be permitted for compatibility sake, albeit with a message that it's no longer needed. (There may be later changes to the internals of ScoreFunction, but that shouldn't change general usage.) POTENTIAL BREAKAGE NOTE: `is_symmetric(ScoreFunction)` and `make_score_function_consistent_with_symmetric_state_of_pose()` from src/core/pose/symmetry/util.hh no longer exist because they're not needed/their old behavior no longer makes sense logically under the new scheme. You can safely remove them from code/PyRosetta scripts -- all ScoreFunctions are consistent with the symmetric state of any pose, and can act like they're symmetric or asymmetric, as need.

Test: linux.gcc.mpi.serialization.integration.mpi

Failed sub-tests (click for more details):