「view this page in B3 βῆτα server」

Revisions №60444

branch: master 「№60444」
Commited by: Labonte
GitHub commit link: 「832ab64447cc856b」 「№3336」
Difference from previous tested commit:  code diff
Commit date: 2018-10-10 08:35:50
linux.clang linux.gcc linux.srlz mac.clang
linux.PyRosetta.unit linux.gcc.python36.PyRosetta4.unit mac.PyRosetta.unit build.clean.debug cppcheck mysql postgres linux.zeromq.debug mpi mpi.serialization linux.icc.build.debug OpenCL build.header build.levels ninja graphics static linux.ui mac.ui build.xcode beautification code_quality.clang_analysis serialization integration.mpi integration.release_debug integration performance profile release.PyRosetta4.Release release.source linux.clang.score linux.gcc.score mac.clang.score linux.scripts.pyrosetta scripts.rosetta.parse scripts.rosetta.validate scripts.rosetta.verify linux.clang.unit.release linux.gcc.unit.release

Merge pull request #3336 from RosettaCommons/JWLabonte/sugars/database Carbohdyrates: unit test to check stereochem./atom-placement of monosacharide residues in the database This merge adds a complicated "dynamic" unit test that used a "rubric" file with expected answers to check carbohydrate .params files for ICOOR errors. The errors it checks for include: Proper superimposition of virtual atoms with real atoms Expected stereochemistry of ring atoms (based on a rubric data file, stereochem_test.key) Expected ring conformer (based on the same rubric file) Hydrogen placement The test checks both reducing-end and non-reducing end versions of the residues, by creating disaccharides. The unit test reveals an assortment of ICOOR errors, as I expected, which I am systematically fixing. Notably, post-merge, hydrogen placement should always be correct — the problem was in the patch files for lower termini — and the RingConformerSet should correctly assign the current RingConformer consistently — the problem was in virtual atom superimposition. I have also decided to organize the .params files in a deeper subdirectory scheme. Finally, and perhaps most significantly, I have "idealized" heavy atom ICOOR records to use simpler, average, less precise values. I do not think this will affect scientific performance, though it may affect Cartesian minimization. If it does not, I think this is a better, more standardized way of writing sugar .params files and will simplify the implementation of my long desire to script the generation of hundreds of possible topography files for future design work. All unit tests pass. This merge will result in integration test changes for ALL tests involving glycans, as literally every sugar .params file has been modified.

Test: linux.gcc.python36.PyRosetta4.unit

 View log


 View log in dialog  View log in log in separate window