WARNINGS WAR Z: Turing on Werror for all builds.
List of warning types removed in this round:
* Wheader-guard -- This occurs when one has a typo in his or her header
guards. For example:
#ifndef INCLUDED_core_scoring_MyEnergy_HH
#define INCLUDED_core_scoring_myEnergy_HH
* Wself-assign-field -- This occurs when you write code like this:
foo = foo;
* Wliteral-conversion -- This occurs when you are using raw values -- which
you never should be doing -- and those raw values are
then cast with a loss of precision. For example:
void my_function(int bar) { // do stuff }
my_function(1.23456);
* Wstring-plus-int -- These occur in three varieties and in EVERY case they
occured within utility_exit_with_message(). (Fixing
these should greatly improve the error helpfulness of
Rosetta.) This occurs when you try to append an int to
a string with +. utility_exit_with_message() takes a
string, not a stream, so you can't do this. The three
varieties are when folks try to append ints, chars, or
enums, which the compiler will treat the same.
To append a char to a string use:
+ std::string(1, my_char)
To append am int or an enum, I like to use boost::
lexical_cast, but there are other methods also.
(A plug for Clang -- all of these were only caught by Clang 3.4, which the test
server uses.)
* Wunitialized -- This occurs usually when your code makes assumptions that may
well be correct, but the compiler cannot figure that out. If
I could figure them out, I fixed them, but in a few cases I
could not, so I have shut this warning OFF until I can find
those of you who can fix this one.
This also occurs if you try to instantiate an object from
within its own constructor!
Also, I have cleaned, sorted, and organized basic.settings. Hopefully, it will
be easier to find where settings are located now.
----------------------------------------
Unit test status: Pass
Integration test status: 6 tests changed, all of which are the result of my
fixing what I believe to have been a bug do to a cast
of raw float values to a boolean [Wliteral-conversion]
antibody_designer
antibody_H3
antibody_H3_legacy
pepspec
hotspot_graft
dock_with_hotspot