Merge pull request #2559 from RosettaCommons/vmullig/threadsafe_elec2
Fix a thread safety issue in FA_ElecEnergy method: scratch space was shared between cloned instances
The scratch space object was being deep-cloned by the `FA_ElecEnergy::clone()` operation. Now, the operation creates new scratch space. I _think_ this will solve the problem that I'm seeing on Blue Gene by ensuring that the scratch space object is always thread-local.
Tasks:
- [x] Fix the cloning issue.
- [x] Beauty.
- [x] Test on Blue Gene/Q.
- [x] Check unit tests.
- [x] Check integration tests.
- [x] Beautify (since master is not beautiful).